Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add annotation Module #175

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

add annotation Module #175

wants to merge 3 commits into from

Conversation

pjl54
Copy link
Contributor

@pjl54 pjl54 commented May 5, 2020

No description provided.

AnnotationModule.py Outdated Show resolved Hide resolved
AnnotationModule.py Outdated Show resolved Hide resolved
AnnotationModule.py Outdated Show resolved Hide resolved
Copy link
Owner

@choosehappy choosehappy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a few minor house keeping issues in the code

one important component missing...you never mention how/where/what these xml files look like. how are they generated? you can add a lot of this information in as a comment at the top of the module

can you also create a directory called "AnnotationModule", you can move your config file in there, and provide a full example of an xml file in there. i think that should nicely cover documentation needs

AnnotationModule.py Show resolved Hide resolved
BaseImage.py Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants